-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing after review #29
Conversation
@@ -408,13 +408,13 @@ The cbor representation of a consistency proof for RFC9162_SHA256 is: | |||
~~~~ cddl | |||
consistency-proof = bstr .cbor [ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also believe it should be possible for a consistency proof to show consistency between two arbitrary points in the log. So the 'older' / 'newer' frazing seems like an improvement to me also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first sentence could be clearer, but the rest of these changes are improvements.
Co-authored-by: Orie Steele <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with, or without the nit suggestion at line 302
Co-authored-by: Steve Lasker <[email protected]>
With this PR I address my comments on editing in this review: https://mailarchive.ietf.org/arch/msg/cose/b7ZLpC3U5CNhQscCi6ErDvFk9kg/
Some reasoning.