Remove line on switching VDSes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
approved these changes
Aug 5, 2024
|
This argument makese sense to me. I am conflicted about re-use too. I raised this PR today: #26 It could be seen as either "making things worse" according to this issue, but possibly "threading the needle" by pushing full responsibility for re-use on to the confirming specification. I am neutral on both this and my own PR, but very interested in the authors comments |
SteveLasker
approved these changes
Aug 6, 2024
henkbirkholz
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest removing the line on migrating between VDSes. I think it's good that the draft addresses an overlap in VDPs. However, I fear that the line I suggest removing might invite people to not worry about security. I think it could be parsed as: "Probably, switching works."
Without the line, I think the draft now emphasizes that (a) you shouldn't expect that overlap in similar concepts leads to the same result, and (b) you must always consider security when migrating.