refactor more cpp #122
Open
refactor more cpp #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gocarlos
commented
May 25, 2020
| target_link_libraries(cose_dumper PRIVATE cn-cbor::cn-cbor cose-c::cose-c) | ||
| if(MSVC) | ||
| target_link_libraries(cose_dumper PRIVATE ws2_32) | ||
| endif() | ||
|
|
||
| target_include_directories(cose_dumper PRIVATE ../src) | ||
| target_compile_options(cose_dumper PRIVATE "-fpermissive") |
There was a problem hiding this comment.
as we are using cpp, we can overload functions -> we should get rid if macros that insert , context to the argument list IMHO
There was a problem hiding this comment.
It is not going to be possible to remove all of these macros as the CBOR library is still in C. I am also not too sure how much one can rely on linkers to not require functions exist, I know that one can compile each function into a separate block for MSVC but I don't know for sure that this exists in gcc and clang as they are not the compilers that I use much
jimsch
reviewed
May 25, 2020
| @@ -28,7 +28,7 @@ typedef struct _cose_mac* HCOSE_MAC; | |||
| typedef struct _cose_mac0* HCOSE_MAC0; | |||
| typedef struct _cose_counterSignature* HCOSE_COUNTERSIGN; | |||
| typedef struct _cose_counterSignature1* HCOSE_COUNTERSIGN1; | |||
| typedef struct _cose_key* HCOSE_KEY; | |||
| typedef class COSE_KEY* HCOSE_KEY; | |||
There was a problem hiding this comment.
My C compiler is going to produce an error over the word class in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits for detailed infos