Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#290 plugin not compatible with gradle configuration cache #312

Merged
merged 8 commits into from
Jul 17, 2024
Merged

#290 plugin not compatible with gradle configuration cache #312

merged 8 commits into from
Jul 17, 2024

Conversation

simonhauck
Copy link
Collaborator

@simonhauck simonhauck commented Jul 8, 2024 •
edited
Loading

🚀 Description

Provide the formatting options as property

📄 Motivation and Context

#290

🧪 How Has This Been Tested?

Added integration tests.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@simonhauck
#290 Add tests to reproduce issues with configuration cache and custo…
2f08ca3 
…m format tasks
@simonhauck
#290 provide formatting options bean as property instead to be compat…
7555c63 
…ible with configuration cache

- Tasks are not allowed to invoke the project extension when using the configuration cache
@simonhauck simonhauck added the bug Something isn't working label Jul 8, 2024
@simonhauck simonhauck linked an issue Jul 8, 2024 that may be closed by this pull request
Plugin not compatible with Gradle configuration cache #290
Closed
@simonhauck simonhauck marked this pull request as ready for review July 12, 2024 13:13
cortinico
cortinico approved these changes Jul 12, 2024
View reviewed changes
Copy link
Owner

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 thanks for tackling this

plugin-build/plugin/src/main/java/com/ncorti/ktfmt/gradle/KtfmtPlugin.kt Outdated Show resolved Hide resolved
@simonhauck
Copy link
Collaborator Author

I have also edited the CHANGELOG and removed the entries. In the other story you mentioned, that this is not relevant for the users. This is the same for these changes.

cortinico
cortinico approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @simonhauck ! Thanks for tackling this one

@simonhauck simonhauck merged commit fc30ff1 into main Jul 17, 2024
4 checks passed
@simonhauck simonhauck deleted the 290-plugin-not-compatible-with-gradle-configuration-cache branch July 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin not compatible with Gradle configuration cache
2 participants
@simonhauck @cortinico