Merge pull request #130 from cortexproject/fix-walk-call-test

cortexproject · Nov 2, 2024 · 4051538 · 4051538
2 parents 39de2f9 + 585513b
commit 4051538
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/walk_test.go b/walk_test.go
@@ -85,6 +85,12 @@ func TestWalkCall(t *testing.T) {
 			}
 			require.True(t, slices.Contains(tc.valueTypes, c.Func.ReturnType))
 			for i, arg := range c.Args {
+				// Only happen for functions with variadic set to -1 like label_join.
+				// Hardcode its value to ensure it is string type.
+				if i >= len(c.Func.ArgTypes) {
+					require.Equal(t, parser.ValueTypeString, arg.Type())
+					continue
+				}
 				require.Equal(t, c.Func.ArgTypes[i], arg.Type())
 			}
 		})