Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnx2keras #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

onnx2keras #3

wants to merge 6 commits into from

Conversation

bang6319
Copy link
Collaborator

Hey Sarah,

Here's my onnx2keras feature branch

Copy link
Collaborator

@sarahaguasvivas sarahaguasvivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, Bao,

Now, let's see if it integrates well with the rest of the software

from onnx2keras import onnx_to_keras

def onnx2keras(file):
# Load ONNX model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more comments on what the function does using this template:

        /*------------------------------------------------- FUNCTION_NAME -----
         |  Function FUNCTION_NAME
         |
         |  Purpose:  EXPLAIN WHAT THIS FUNCTION DOES TO SUPPORT THE CORRECT
         |      OPERATION OF THE PROGRAM, AND HOW IT DOES IT.
         |
         |  Parameters:
         |      parameter_name (IN, OUT, or IN/OUT) -- EXPLANATION OF THE
         |              PURPOSE OF THIS PARAMETER TO THE FUNCTION.
         |                      (REPEAT THIS FOR ALL FORMAL PARAMETERS OF
         |                       THIS FUNCTION.
         |                       IN = USED TO PASS DATA INTO THIS FUNCTION,
         |                       OUT = USED TO PASS DATA OUT OF THIS FUNCTION
         |                       IN/OUT = USED FOR BOTH PURPOSES.)
         |
         |  Returns:  IF THIS FUNCTION SENDS BACK A VALUE VIA THE RETURN
         |      MECHANISM, DESCRIBE THE PURPOSE OF THAT VALUE HERE.
         *-------------------------------------------------------------------*/

@@ -0,0 +1,27 @@
from nn4mc.parser._parser import Parser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO(sarahaguasvivas): Use test_translator to see if nn4mc doesn't crash with these models:

https://github.com/correlllab/nn4mc_py/blob/master/tests/test_translator/test_full.py

Create a new one called test_full_onnx.py

Hi,

Here is the def parseWeights that I made for _onnxparser.py based on one from HDF5.

Bao
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants