fix: Stop throwing errors when calling removeToolState if toolData or… (

#1181) * fix: Stop throwing errors when calling removeToolState if toolData or toolData.data do not exist * chore: update autofix to new vscode format * chore: apply autofix (fixes broken build) Co-authored-by: Danny Brown <[email protected]>
cornerstonejs · Feb 20, 2020 · 1682fa8 · 1682fa8
1 parent 4e430ba
commit 1682fa8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -69,5 +69,8 @@
   "[markdown]": {
     "editor.wordWrap": "wordWrapColumn",
     "editor.wordWrapColumn": 80
+  },
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
   }
 }
diff --git a/src/stateManagement/toolState.js b/src/stateManagement/toolState.js
@@ -80,6 +80,11 @@ function getToolState(element, toolType) {
 function removeToolState(element, toolType, data) {
   const toolStateManager = getElementToolStateManager(element);
   const toolData = toolStateManager.get(element, toolType);
+
+  if (!toolData || !toolData.data || !toolData.data.length) {
+    return;
+  }
+
   // Find this tool data
   let indexOfData = -1;
 

diff --git a/src/tools/OverlayTool.js b/src/tools/OverlayTool.js
@@ -104,10 +104,12 @@ export default class OverlayTool extends BaseTool {
       }
 
       // Guard against non-number values
-      const overlayX = (!isNaN(parseFloat(overlay.x)) && isFinite(overlay.x)) ? overlay.x : 0;
-      const overlayY = (!isNaN(parseFloat(overlay.y)) && isFinite(overlay.y)) ? overlay.y : 0; 
-
+      const overlayX =
+        !isNaN(parseFloat(overlay.x)) && isFinite(overlay.x) ? overlay.x : 0;
+      const overlayY =
+        !isNaN(parseFloat(overlay.y)) && isFinite(overlay.y) ? overlay.y : 0;
       // Draw the overlay layer onto the canvas
+
       canvasContext.drawImage(layerCanvas, overlayX, overlayY);
     });
   }