-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internet proxy config #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Two small nits:
- we use single space in the docs.
- not sure you wanted to add that nginx.conf file here
Thanks for working on this! |
@travier you're welcome. Issues resolved. I'm not familiar with protocols here and whether I am expected to mark things above as resolved, or whether that is for you given you raised the questions? |
I think you can mark them as resolved yourself, at least that's what I do. |
Thanks for working on this @fifofonix - looking good to me. Let's get that nginx.conf file broken out into a separate commit and then the extraneous two commits that you have right now squashed. At the end I'm thinking two commits:
|
fb1b784
to
1c69425
Compare
This LGTM - only thing I would add is maybe linking to the original location where the @travier do you want to do one more review pass? |
1c69425
to
c689f67
Compare
Done |
If you can update your commit message to mention https://gitlab.com/fedora/docs/templates/fedora-docs-template/-/blob/main/nginx.conf instead as it's the template repo that would be great. LGTM otherwise. |
Required for ./build.sh && ./preview.sh on MacOS (file copied from https://gitlab.com/fedora/docs/templates/fedora-docs-template/-/blob/main/nginx.conf)
c689f67
to
f585e49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Concerns: #469
Also, adds a default nginx.conf file which is necessary for preview.sh to function out of the box for MacOS users.