install: Don't require the network by default #1335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to test this. CI tests the online flow, but it'd be good to also sanity-check that DNS lookup failures are also caught by the retry logic. |
jlebon
force-pushed
the
pr/no-network
branch
2 times, most recently
from
2059aa7 to
e6bc574
Compare
The `Wants=network-online.target` predates the osmet work which enabled the now default fully offline install flow. It also predates the addition of fetch retries. So even in an online flow, now that we retry HTTP requests indefinitely, we don't really need this. Let's follow best practices and stop pulling in `network-online.target`. We still need to keep pulling in `NetworkManager.service` though. It's enabled by default in `multi-user.target` but not `coreos-installer-post.target` (which is what we boot to in an automated install). NetworkManager is capable of handling offline environments just fine and won't block the install just because a connection isn't available (yet or ever). Related: coreos/fedora-coreos-config#1088 Related: coreos#565 (comment) Related: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ Closes: https://github.com/coreos/coreos-installer/issues/1334
jlebon
force-pushed
the
pr/no-network
branch
2 times, most recently
from
d42ab91 to
15b9d3a
Compare
We don't need this anymore now that we do retry HTTP fetches.
jlebon
force-pushed
the
pr/no-network
branch
from
15b9d3a to
7202894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Wants=network-online.targetpredates the osmet work which enabledthe now default fully offline install flow.
It also predates the addition of fetch retries. So even in an online
flow, now that we retry HTTP requests indefinitely, we don't really
need this.
Let's follow best practices and stop pulling in
network-online.target.We still need to keep pulling in
NetworkManager.servicethough. It's enabled by default in
multi-user.targetbut notcoreos-installer-post.target(which is what we boot to in an automatedinstall).
NetworkManager is capable of handling offline environments just fine and
won't block the install just because a connection isn't available (yet
or ever).
Related: coreos/fedora-coreos-config#1088
Related: #565 (comment)
Related: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Closes: https://github.com/coreos/coreos-installer/issues/1334