Skip to content

Commit

Permalink
rdcore: fail if system has more than 1 boot partition
Browse files Browse the repository at this point in the history
Signed-off-by: Nikita Dubrovskii <[email protected]>
  • Loading branch information
nikita-dubrovskii committed Oct 5, 2021
1 parent e899478 commit 3c7ae4b
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 0 deletions.
1 change: 1 addition & 0 deletions dracut/50rdcore/module-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ install() {
local _arch=${DRACUT_ARCH:-$(uname -m)}

inst_simple "$moddir/rdcore" "/usr/bin/rdcore"
inst_multiple partprobe

# `rdcore kargs` calls `zipl` on s390x
if [[ "$_arch" == "s390x" ]]; then
Expand Down
9 changes: 9 additions & 0 deletions src/bin/rdcore/cmdline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ pub enum Cmd {
Kargs(KargsConfig),
/// Copy data from stdin to stdout, checking piecewise hashes
StreamHash(StreamHashConfig),
/// Verify that system has only 1 partition with given label
SinglePartition(PartitionLabelConfig),
}

#[derive(Debug, StructOpt)]
Expand Down Expand Up @@ -95,3 +97,10 @@ pub struct StreamHashConfig {
#[structopt(value_name = "hash-file")]
pub hash_file: String,
}

#[derive(Debug, StructOpt)]
pub struct PartitionLabelConfig {
/// Path to the piecewise hash file
#[structopt(value_name = "label")]
pub label: String,
}
2 changes: 2 additions & 0 deletions src/bin/rdcore/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
mod cmdline;
mod kargs;
mod rootmap;
mod single_partition;
mod stream_hash;

use anyhow::Result;
Expand All @@ -27,5 +28,6 @@ fn main() -> Result<()> {
Cmd::Kargs(c) => kargs::kargs(&c),
Cmd::Rootmap(c) => rootmap::rootmap(&c),
Cmd::StreamHash(c) => stream_hash::stream_hash(&c),
Cmd::SinglePartition(c) => single_partition::verify_single_partition(&c),
}
}
32 changes: 32 additions & 0 deletions src/bin/rdcore/single_partition.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Copyright 2020 CoreOS, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use crate::cmdline::*;
use anyhow::{bail, Result};

use libcoreinst::blockdev::*;

pub fn verify_single_partition(config: &PartitionLabelConfig) -> Result<()> {
// fail if we have more than 1 partition with boot label
let devices = get_all_block_devices()?;
let amount = count_partitions_with_label(&config.label, &devices.blockdevices);
if amount != 1 {
bail!(
"System has {} partitions with '{}' label",
amount,
config.label
);
}
Ok(())
}

0 comments on commit 3c7ae4b

Please sign in to comment.