Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package to Laravel 9 compatibility #102

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Update package to Laravel 9 compatibility #102

wants to merge 19 commits into from

Conversation

ishigami
Copy link

  • I've merged develop branch (outdated) with the master branch.
  • Added the corcel/corcel version to ^6.0
  • Added phpunit version to ^9.0
  • Updated readme.md to add latest corcel version
  • Updated phpunit.xml schema

PHPunit test results:

PHPUnit 9.5.16 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.15
Configuration: /Volumes/kandisk/work/open-source-works/acf/phpunit.xml

...................................S............                  48 / 48 (100%)

Time: 00:00.209, Memory: 12.00 MB

There was 1 skipped test:

1) JqueryFieldsTests::testGoogleMapField
Google Map field i s not working at the moment

/Volumes/kandisk/work/open-source-works/acf/tests/JqueryFieldsTest.php:21

OK, but incomplete, skipped, or risky tests!
Tests: 48, Assertions: 105, Skipped: 1.

jgrossi and others added 19 commits March 22, 2019 14:50
@jgrossi
Merge pull request corcel#76 from corcel/develop
8091c7c 
Release last changes on develop branch
@jgrossi
Merge pull request corcel#83 from corcel/develop
813ffb4 
Update to Corcel 3.0
@rezsk
Upgrading Corcel to match Laravel 7 requirements
8b9afbc
@jgrossi
Merge pull request corcel#90 from rez0sk/master
fbf480b 
Upgrading Corcel to match Laravel 7 requirements
@squatto
Add Corcel 5.x and PHPUnit 9.x support
ee28e38 
Also bumped PHPUnit from `^8.0` to `^8.4` to match Laravel 8
@squatto
Add "Version Compatibility" section to readme
c01a5d4
@squatto
Updated travis build config
11d84bf 
* Corcel v4 tested with PHP 7.2, 7.3, and 7.4
* Corcel v5 tested with PHP 7.3 and 7.4
* Removed deprecated/ignored `sudo` setting
* Moved database import process into `before_script`
* Moved `composer self-update` into `before_install`
* Moved `composer install` into `install`
@squatto
Fix composer require
ab5f17c
@squatto
Tweak the way PHP version + Corcel version is handled in travis.yml
32ed492
@squatto
Use the right package name for jgrossi/corcel 🤦🏼‍
7089546
@squatto
Go back to the simplified matrix->include travis config
2976b78
@squatto
Delete composer.lock before installing
f3c2ba2
@jgrossi
Merge pull request corcel#94 from squatto/laravel-8-support
a96ed6a 
Laravel 8 support
@jgrossi @StyleCIBot
Apply fixes from StyleCI
ef3d747
@ishigami
Bump packages versions to Laravel 9
d9eb1d3
@ishigami
Bump packages versions to Laravel 9
a283540
@ishigami
Update phpunit.xml to new schema
188d5ef
@ishigami
Remove phpunit.xml.bak
01e3dfc
@ishigami
Remove database.sql
97b4678
@antodd
Copy link

antodd commented Mar 10, 2022

👍 @jgrossi . It would be great to have the latest Corcel and Laravel supported in this package.

@sietzekeuning
Copy link

can this please be merged?

@AntonCooper
Copy link

+1 for getting a release for this. Would be super helpful

@fidovdbos
Copy link

fidovdbos commented Jun 6, 2022 •
edited
Loading

@jgrossi @jakobbuis Please release this version including the corcel 6 implementation so we can continue to use this

@georgi-vdimitrov
Copy link

+1. We still need this @jgrossi. Thanks in advance!

@XenBG
Copy link

XenBG commented Jan 18, 2023

+1

1 similar comment
@aon4o
Copy link

aon4o commented Jan 18, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.