Fix highlights #805
Merged
Fix highlights #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtetley
force-pushed
the
fix-highlights
branch
2 times, most recently
from
5818c4b
to
5dcef54
Compare
gares
reviewed
Jul 9, 2024
language-server/dm/document.ml
Outdated
| (List.map (fun (_,x) -> Sentence x) @@ SM.bindings parsed.sentences_by_id) ; | ||
| (List.map (fun (_,x) -> Sentence x) @@ LM.bindings parsed.sentences_by_end) ; |
There was a problem hiding this comment.
this should be reverted, or better the two maps should be printed for future debugging
gares
reviewed
Jul 9, 2024
Comment on lines
-238
to
+247
| let sentences_by_end = LM.remove old_sentence.stop parsed.sentences_by_end in | ||
| let sentences_by_end = match LM.find_opt old_sentence.stop parsed.sentences_by_end with | ||
| | Some { id } when Stateid.equal id new_sentence.id -> | ||
| LM.remove old_sentence.stop parsed.sentences_by_end | ||
| | _ -> parsed.sentences_by_end | ||
| in |
|
It would be nice to have some unit tests on the contents of |
|
If we remove the debug prints I believe we could merge and release |
A nasty bug would overwrite a sentence if by chance they had the same end loc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a non-invalidating edit, the exec overview needs to be shifted (like for the diagnostics).
Closes #803