Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capabilities for outline #795

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Capabilities for outline #795

merged 4 commits into from
Jul 12, 2024

Conversation

rtetley
Copy link
Collaborator

@rtetley rtetley commented Jun 24, 2024

No description provided.

@rtetley rtetley force-pushed the overview branch 2 times, most recently from 7f2f495 to 0bc27c4 Compare June 26, 2024 07:39
@rtetley rtetley requested a review from gares June 26, 2024 07:39
@rtetley
Copy link
Collaborator Author

rtetley commented Jun 26, 2024

@gares if you can briefly review this then I'll merge and use it as a basis for further work using the "outline"

gares
gares reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@gares gares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is about invalidation. What do you do?
It seems you do nothing when a sentence is removed and I guess you should follow what the scheduler does.

@gares
Copy link
Collaborator

gares commented Jun 27, 2024

A nitpick. In OCaml let... in is well delimited, so if in the body you use a match, you don't necessarily need a begin end.

@rtetley
Working outline
57ed95c 
We implement the documentSymbol capacity, which allows for the user to use the outline feature of vscode.
@rtetley
Different symbol kinds for theorem_kind and definition_kind
29f1f95
@rtetley rtetley merged commit 6bc66f8 into main Jul 12, 2024
23 checks passed
@rtetley rtetley deleted the overview branch July 12, 2024 15:13
@rtetley rtetley mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gares gares gares left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtetley @gares