Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscoq 2.1.3, break seems broken #803

Closed
thery opened this issue Jun 26, 2024 · 2 comments · Fixed by #805
Closed

vscoq 2.1.3, break seems broken #803

thery opened this issue Jun 26, 2024 · 2 comments · Fixed by #805
Labels
bug Something isn't working

Comments

@thery
Copy link
Collaborator

thery commented Jun 26, 2024

Here is my example

Goal forall A B C D E F : Prop, A -> B -> C -> D -> E -> F -> A.
Proof.
intros A B C D E F.
intros HA; intros HB; intros HC; intros HD; intros HE; intros HF; exact HA.
Qed.

if I execute everything
ddd1
if I try to break the line after HE;
The interface goes into an inconsistent state
ddd2
@rtetley rtetley added the bug Something isn't working label Jun 27, 2024
@gares
Copy link
Collaborator

gares commented Jun 27, 2024

I think the range stuff was not invalidated since the document is not.
The code did detect that the texts parses to the same token list, so no need to recompute.
But since the new text is different in length/number-of-lines, the highlighting state needs to be invalidated hence recomputed.

@gares
Copy link
Collaborator

gares commented Jun 27, 2024

The colors did not move at all, this is why I'm giving this analysis of the bug.

@rtetley rtetley mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix highlights coq-community/vscoq
3 participants
@gares @thery @rtetley