-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Docker notification logic to health check #2332 #2725
base: next
Are you sure you want to change the base?
Conversation
v4.0.0-beta.301
Refactor default_environment method to handle projects with 0 environ…
v4.0.0-beta.302
fix fix fix
v4.0.0-beta.303
v4.0.0-beta.304
v4.0.0-beta.305
v4.0.0-beta.306
@cmer @wutangpaul @AshKyd @mauvehed plss review the pr |
…ead of increasing counter++
Ok from now on we have to wait until andras reviews 😊 whenever he approves & merges the pr the bounty is rewarded. Thank you so far already! |
@EinfachHans ok thanks for helping me in everything |
Quick reminder, your PR should merge to coolify |
@alexzvn ok so do i have to do anything because sorry i dont get your comment? can u plss elaborate |
@Anshgrover23 you have to adjust your pr' target branch, which currently points to the |
@EinfachHans @alexzvn ok doing it |
@andrasbacsai @alexzvn done all changes ready for merge |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12428579 | Triggered | Generic Password | a5a2116 | app/Http/Controllers/Api/DatabasesController.php | View secret |
12428579 | Triggered | Generic Password | 9be3229 | app/Http/Controllers/Api/DatabasesController.php | View secret |
12428579 | Triggered | Generic Password | a5a2116 | app/Http/Controllers/Api/DatabasesController.php | View secret |
12428579 | Triggered | Generic Password | a5a2116 | app/Http/Controllers/Api/DatabasesController.php | View secret |
12661388 | Triggered | Generic Password | a5a2116 | app/Http/Controllers/Api/DatabasesController.php | View secret |
12661388 | Triggered | Generic Password | a5a2116 | app/Http/Controllers/Api/DatabasesController.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@EinfachHans when will it get merged may I know the reason why no one is viewing my pr? |
@EinfachHans @andrasbacsai is there anything wrong? |
@Anshgrover23 Stop spamming please... Andras is running coolify alone. He will review the pr whenever he has the time for it. Tagging him or anyone else is not helping in any way. Just wait ✌🏼 |
@EinfachHans ok sorry for spamming |
@EinfachHans can i ask you a question when will i rewarded that bounty because i thought the andras will ckeck it and i will get it or i have to make more changes to this pr i it so? |
@Anshgrover23 the bounty is rewarded when the pr is merged. If you have to do more changes, i can not tell you. You have to wait for andras review. |
@EinfachHans ok bro. |
/claim #2332
Fixes: #2332
Summary:
This PR adds a notification mechanism for health check status changes in the ApplicationDeploymentJob class.
Changes:
Notification Logic:
Added sendDockerNotification method to log and send Docker events for health status changes.
Integrated this method into the health_check function to detect and notify on status changes.
File Modified:
src/Jobs/ApplicationDeploymentJob.php: Added notification logic and ensured proper placement.
Testing:
Added and executed unit tests.
Performed manual testing to verify functionality.