Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Docker notification logic to health check #2332 #2725

Open
wants to merge 18 commits into
base: next
Choose a base branch
from

Conversation

Anshgrover23
Copy link

@Anshgrover23 Anshgrover23 commented Jun 30, 2024

/claim #2332
Fixes: #2332

Summary:
This PR adds a notification mechanism for health check status changes in the ApplicationDeploymentJob class.

Changes:

Notification Logic:

Added sendDockerNotification method to log and send Docker events for health status changes.
Integrated this method into the health_check function to detect and notify on status changes.
File Modified:

src/Jobs/ApplicationDeploymentJob.php: Added notification logic and ensured proper placement.
Testing:

Added and executed unit tests.
Performed manual testing to verify functionality.

@Anshgrover23
Copy link
Author

@cmer @wutangpaul @AshKyd @mauvehed plss review the pr

@Anshgrover23 Anshgrover23 changed the title Add Docker notification logic to health check # Feat: Add Docker notification logic to health check #2332 Jun 30, 2024
@EinfachHans
Copy link

Ok from now on we have to wait until andras reviews 😊 whenever he approves & merges the pr the bounty is rewarded. Thank you so far already!

@Anshgrover23
Copy link
Author

@EinfachHans ok thanks for helping me in everything

@alexzvn
Copy link
Contributor

alexzvn commented Jun 30, 2024

Quick reminder, your PR should merge to coolify next branch

@Anshgrover23
Copy link
Author

@alexzvn ok so do i have to do anything because sorry i dont get your comment? can u plss elaborate

@EinfachHans
Copy link

@Anshgrover23 you have to adjust your pr' target branch, which currently points to the main branch

@Anshgrover23
Copy link
Author

@EinfachHans @alexzvn ok doing it

@Anshgrover23 Anshgrover23 changed the base branch from main to next June 30, 2024 13:03
@Anshgrover23
Copy link
Author

@andrasbacsai @alexzvn done all changes ready for merge

Copy link

gitguardian bot commented Jul 1, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12428579 Triggered Generic Password a5a2116 app/Http/Controllers/Api/DatabasesController.php View secret
12428579 Triggered Generic Password 9be3229 app/Http/Controllers/Api/DatabasesController.php View secret
12428579 Triggered Generic Password a5a2116 app/Http/Controllers/Api/DatabasesController.php View secret
12428579 Triggered Generic Password a5a2116 app/Http/Controllers/Api/DatabasesController.php View secret
12661388 Triggered Generic Password a5a2116 app/Http/Controllers/Api/DatabasesController.php View secret
12661388 Triggered Generic Password a5a2116 app/Http/Controllers/Api/DatabasesController.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Anshgrover23
Copy link
Author

@EinfachHans when will it get merged may I know the reason why no one is viewing my pr?

@Anshgrover23
Copy link
Author

@EinfachHans @andrasbacsai is there anything wrong?

@EinfachHans
Copy link

@Anshgrover23 Stop spamming please... Andras is running coolify alone. He will review the pr whenever he has the time for it. Tagging him or anyone else is not helping in any way. Just wait ✌🏼

@Anshgrover23
Copy link
Author

@EinfachHans ok sorry for spamming

@Anshgrover23
Copy link
Author

@EinfachHans can i ask you a question when will i rewarded that bounty because i thought the andras will ckeck it and i will get it or i have to make more changes to this pr i it so?

@EinfachHans
Copy link

@Anshgrover23 the bounty is rewarded when the pr is merged. If you have to do more changes, i can not tell you. You have to wait for andras review.

@Anshgrover23
Copy link
Author

@EinfachHans ok bro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Healthcheck improvements
4 participants