Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce https #2693

Open
wants to merge 9 commits into
base: next
Choose a base branch
from
Open

fix: enforce https #2693

wants to merge 9 commits into from

Conversation

mooxl
Copy link

@mooxl mooxl commented Jun 25, 2024

This PR should fix #1880 by making the $is_stripprefix_enabled parameter default to true, similar to the $is_gzip_enabled parameter, and pushing it to the other middlewares.

After investigating this issue, I've recognized that it doesn't matter whether "Enable gzip compression" or "Force Https" is disabled in the "Advanced" section. The default parameter is always applied. This can be considered a temporary fix until the underlying issue with providing the correct parameters to the function is resolved.

Never wrote php so please be kind:)

Copy link

sentry-io bot commented Jun 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: bootstrap/helpers/docker.php

Function Unhandled Issue
fqdnLabelsForCaddy Spatie\Url\Exceptions\InvalidArgument: The scheme httpa isn't valid. It should be either http, https, mailto, tel. ...
Event Count: 3
fqdnLabelsForCaddy Spatie\Url\Exceptions\InvalidArgument: The string https://{subdomain:[a-z0-9-]+}.bestplay.pl is no valid url. ...
Event Count: 2
fqdnLabelsForCaddy Spatie\Url\Exceptions\InvalidArgument: The string //:3456test.massimomaimeri.com is no valid url. ...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants