Make first parameter optional

conversejs · Nov 15, 2023 · bf7c4ff · bf7c4ff
1 parent f64837a
commit bf7c4ff
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/collection.js b/src/collection.js
@@ -536,7 +536,7 @@ class Collection extends EventEmitter(Object) {
    * Return models with matching attributes. Useful for simple cases of
    * `filter`.
    * @param {Attributes} attrs
-   * @param {boolean} first
+   * @param {boolean} [first]
    */
   where(attrs, first) {
     return this[first ? 'find' : 'filter'](attrs);

diff --git a/src/types/collection.d.ts b/src/types/collection.d.ts
@@ -224,9 +224,9 @@ export class Collection extends Collection_base {
      * Return models with matching attributes. Useful for simple cases of
      * `filter`.
      * @param {Attributes} attrs
-     * @param {boolean} first
+     * @param {boolean} [first]
      */
-    where(attrs: Attributes, first: boolean): any;
+    where(attrs: Attributes, first?: boolean): any;
     /**
      * Return the first model with matching attributes. Useful for simple cases
      * of `find`.

diff --git a/src/types/collection.d.ts.map b/src/types/collection.d.ts.map