Eps error tracking #11

AaronColbyPrice · 2023-01-03T16:41:31Z

DO NOT MERGE - internal code review only

Sync'ing from upstream

pycnvr · 2023-01-03T22:26:28Z

modules/conversantAnalyticsAdapter.js

 } = CONSTANTS;
+// STALE_RENDER, TCF2_ENFORCEMENT would need to add extra calls for these as they likely occur after AUCTION_END?


Yes, STALE_RENDER would occur after AUCTION_END. There could be several STALE_RENDER after an auction has ended.

pycnvr · 2023-01-03T22:33:49Z

modules/conversantAnalyticsAdapter.js

+  let bidRequest = args.bidderRequest;
+  let auctionId = bidRequest.auctionId;
+  let bidderCode = bidRequest.bidderCode;
+  logWarn('onBidderError(): error received from bidder ' + bidderCode + '. Status = ' + error.status + ', Message = ' + error.statusText);


Does it need a prefix as well?

pycnvr · 2023-01-03T22:38:28Z

modules/conversantAnalyticsAdapter.js

+  } else {
+    cnvrHelper.bidderErrorCache[auctionId] = {
+      errors: [errorObj],
+      timeReceived: Date.now()


Only the first error has a timestamp?

@pycnvr yes since they are relative to an auction, I want to grab them all as a list. The timeReceived is there to purge the cache in case it doesn't get removed by an AUCTION_END event.

pycnvr · 2023-01-03T22:45:26Z

modules/conversantAnalyticsAdapter.js

+ */
+cnvrHelper.sendErrorData = function(eventType, exception) {
+  if (!cnvrHelper.doSendErrorData) {
+    logWarn('Skipping sending error data due to config disabling error logging, error thrown = ' + exception);


pycnvr · 2023-01-03T23:25:50Z

modules/conversantAnalyticsAdapter.js

@@ -529,6 +644,10 @@ conversantAnalytics.enableAnalytics = function (config) {
  // Math.random() pseudo-random number in the range 0 to less than 1 (inclusive of 0, but not 1)
  cnvrHelper.doSample = Math.random() < initOptions.cnvr_sample_rate;

+  if (initOptions.send_error_data !== undefined && initOptions.send_error_data !== null && typeof initOptions.send_error_data === 'boolean') {


There is a isBoolean function in utils.js. However, it's usually sufficient to do a double-negation like this without having to check whether it's a boolean.

cnvrHelper.doSendErrorData = !!initOptions.send_error_data;

a bit obscure but I added a comment to inform of what it's doing

pycnvr · 2023-01-04T00:19:58Z

test/spec/modules/conversantAnalyticsAdapter_spec.js

  });

  describe('Initialization Tests', function() {
    it('should log error if site id is not passed', function() {
      sandbox.stub(utils, 'logError');
-
+      conversantAnalytics.disableAnalytics();


Is this needed?

Yes, was running the tests before and since I put in a global initialization to avoid putting it in for 90% of the test cases I have to reset here.

AfterEach should have already called conversantAnalytics.disableAnalytics() and that why this seems redundant.

pycnvr · 2023-01-04T00:21:21Z

test/spec/modules/conversantAnalyticsAdapter_spec.js

  });

  afterEach(function () {
    sandbox.restore();
    requests = []; // clean up any requests in our ajax request capture array.
+    conversantAnalytics.disableAnalytics();


Should most testcases remove their own copy of conversantAnalytics.disableAnalytics() except for the ones that are testing cleanups?

Yeah, it shouldn't be needed for test cases unless explicitly testing for it

pycnvr · 2023-01-04T00:25:08Z

test/spec/modules/conversantAnalyticsAdapter_spec.js

+      if (arg1) console.log(arg1);
+      if (arg2) console.log(arg2);
+    }); */
+


Remove commented out section?

Yeah, there's an argument to be made to do so. I guess I hate having to figure out how I did this each time I need to debug when I work on this.

pycnvr

Please see questions in the review. Thanks.

…plified errors for recording on back end

- fixing default value - fixing style error

…rebid#10160) Co-authored-by: Michael Denton <[email protected]>

* PE-87: Implement Prebid Adapter (#1) * PE-87: implement BT Bid Adapter * PE-87: rework adapter to use ortbConverter lib, make requested changes * PE-87: update imports * PE-110: Add user sync logic to the Prebid Adapter (#3) * PE-110: add user sync logic * PE-110: update userSync url * PE-110: check if iframe is enabled before setting params * PE-111: BT Prebid Adapter can request AA ads or regular ads (#2) * PE-120: Send Prebid Bidder info to BT Server (#4) * PE-120: add btBidderCode to the bid object * PE-120: use single quotes for logs string * PE-123: Add More Metadata in site.ext.blockthrough (#5) * PE-123: send additional meta data * PE-123: send auctionID under imp.ext.prebid.blockthrough * PE-123: use ortb2 config to set site.ext params * PE-123: sent auctionId in ext.prebid.blockthrough.auctionID * PE-123: update logs for bidderConfig setup * PE-000: check if blockthrough is defined (#6) * PE-87: remove BT specific logic (#7) * Implement Blockthrough Prebid Adapter * PE-87: Implement Prebid Adapter - misc fixes (#9) * PE-87: rename test file, add bidder config * PE-87: increase ttl * PE-000: fix test * BP-74: Change the way we enable debug (#10) * BP-79: Send GPID as a part of `imp[].ext` (#11) * BP-79: send gpid in imp.ext * BP-79: add optional operator * BP-90: Update Cookie Sync Logic (#12) * BP-90: pass bidder to cookie sync * BP-90: update sync logic, fix typo * BP-90: use const for syncs variable * BP-55: Re-add endpoint URLs (#13) * BP-91: Add prebid JS version to auction request (#14)

* create setupadBidAdapter * add setupadBidAdapter * update setupadBidAdapter * update metrics collection * update analytics collection * update getUserSyncs * add setupadAnalyticsAdapter.js * test setupadAnalyticsAdapter * remove test: 1 * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * clean up && seat bugfix * clean up logs * add userID module handling * update md && clean up * Send setupad only on bidRequested * Fix bidResponse and bidWon responses * Improve bidResponse and bidWon logic * Revert changes to specific files * Remove test parameter * Fix multiple bidResponse and bidTimeout calls to getPixelUrl * eslint errors fixes(brackets added) * Add extra checks for events * Fix BIDDER_CODE const * update reporting endpoint * update setupadBidAdapter_spec.js REPORT_ENDPOINT * update readme * Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. * Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * # This is a combination of 20 commits. # This is the 1st commit message: add setupadBidAdapter # This is the commit message #2: update setupadBidAdapter # This is the commit message #3: update metrics collection # This is the commit message #4: update analytics collection # This is the commit message #5: update getUserSyncs # This is the commit message #6: add setupadAnalyticsAdapter.js # This is the commit message #7: test setupadAnalyticsAdapter # This is the commit message #8: remove test: 1 # This is the commit message #9: add GVLID && bug fixes && test updates # This is the commit message #10: remove setupadAnalyticsAdapter # This is the commit message #11: add userID module handling # This is the commit message #12: clean up && seat bugfix # This is the commit message #13: add userID module handling # This is the commit message #14: add GVLID && bug fixes && test updates # This is the commit message #15: remove setupadAnalyticsAdapter # This is the commit message prebid#16: add userID module handling # This is the commit message prebid#17: clean up logs # This is the commit message prebid#18: update md && clean up # This is the commit message prebid#19: Send setupad only on bidRequested # This is the commit message prebid#20: Fix bidResponse and bidWon responses * # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a parent cecfce3 author pavel <[email protected]> 1706627437 +0200 committer pavel <[email protected]> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter * # This is a combination of 26 commits. parent cecfce3 author pavel <[email protected]> 1706627437 +0200 committer pavel <[email protected]> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter # This is the commit message prebid#23: Fix multiple bidResponse and bidTimeout calls to getPixelUrl # This is the commit message prebid#25: eslint errors fixes(brackets added) # This is the commit message prebid#26: Add extra checks for events * parent 75178b9 author pavel <[email protected]> 1706627694 +0200 committer pavel <[email protected]> 1706627694 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA= =Gbog -----END PGP SIGNATURE----- bugfixes update setupadBidAdapter_spec.js REPORT_ENDPOINT update readme Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * change double quote to single quote --------- Co-authored-by: pavel <[email protected]> Co-authored-by: Elgars Grodnis <[email protected]> * bugfix setupadBidAdapter remove getAdEl, spelling correction * add onBidWon event onBidWon event handling moved from custom to native onBidWon method * minor bugfixes && remove funk getSiteObj && getDeviceObj --------- Co-authored-by: pavel <[email protected]> Co-authored-by: Elgars Grodnis <[email protected]>

AaronColbyPrice and others added 5 commits September 9, 2022 13:55

Merge pull request #9 from prebid/master

ba69c20

Sync'ing from upstream

Merge branch 'master' of https://github.com/conversant/Prebid.js

61aaef9

Merge branch 'master' of https://github.com/conversant/Prebid.js

9a48240

Merge branch 'master' of https://github.com/conversant/Prebid.js

689523c

Merge branch 'master' of https://github.com/conversant/Prebid.js

e2a0f1e

AaronColbyPrice requested review from johnwier and pycnvr January 3, 2023 16:41

pycnvr reviewed Jan 3, 2023

View reviewed changes

pycnvr reviewed Jan 4, 2023

View reviewed changes

johnwier approved these changes Jan 4, 2023

View reviewed changes

eps_error_tracking - adding error tracking for epsilon analytics, sim…

cc05546

…plified errors for recording on back end

AaronColbyPrice force-pushed the eps_error_tracking branch from 08cc7af to cc05546 Compare February 10, 2023 22:08

AaronColbyPrice and others added 2 commits February 13, 2023 13:35

Merge branch 'prebid:master' into eps_error_tracking

af64b33

eps_error_tracking - adding error tracking for epsilon analytics

e32f3df

- fixing default value - fixing style error

AaronColbyPrice force-pushed the eps_error_tracking branch from 6c14856 to e32f3df Compare February 14, 2023 01:00

johnwier pushed a commit that referenced this pull request Oct 6, 2023

Cadent Aperture MX Bid Adapter: Change contact email address (#11) (p…

17dafea

…rebid#10160) Co-authored-by: Michael Denton <[email protected]>

johnwier pushed a commit that referenced this pull request Jan 24, 2024

[TECH-6244] fix: add gvlid to adot adapter (#11) (prebid#10975)

65fd605

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eps error tracking #11

Eps error tracking #11

AaronColbyPrice commented Jan 3, 2023

pycnvr Jan 3, 2023

pycnvr Jan 3, 2023

pycnvr Jan 3, 2023

AaronColbyPrice Jan 4, 2023

pycnvr Jan 3, 2023

pycnvr Jan 3, 2023 •

edited

Loading

AaronColbyPrice Jan 5, 2023

pycnvr Jan 4, 2023

AaronColbyPrice Jan 4, 2023

pycnvr Jan 4, 2023

pycnvr Jan 4, 2023

AaronColbyPrice Jan 4, 2023

pycnvr Jan 4, 2023

AaronColbyPrice Jan 4, 2023

pycnvr left a comment

		} = CONSTANTS;
		// STALE_RENDER, TCF2_ENFORCEMENT would need to add extra calls for these as they likely occur after AUCTION_END?

Eps error tracking #11

Are you sure you want to change the base?

Eps error tracking #11

Conversation

AaronColbyPrice commented Jan 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pycnvr Jan 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pycnvr left a comment

Choose a reason for hiding this comment

pycnvr Jan 3, 2023 •

edited

Loading