-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable indexing for unsupported CPUs #3551
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for continuedev canceled.
|
@mjkaye - mind running this command on your Debian Bookworm setup and sharing your output? I'd like to confirm on your machine that you're getting the correct output that will allow us to disable indexing. |
Having the same crash issue. Running ubuntu 22.04, Here is my cpuinfo: processor : 0 |
Below is the content of /proc/cpuinfo, converted to lower-case. I see that you're checking for AVX support, whereas you should be checking for AVX2 support. As you can see from the output, my CPU supports AVX but not AVX2. This can also be seen in @hex20dec's output.
|
Debian Bookworm supports AVX2 and FMA. Instead, this should be tested on a CPU that does not have support for those technologies, such as Sandy Bridge and Ivy Bridge Intel CPUs. |
Description
Continue currently uses LanceDB for our vector search, but their binaries require that the target CPU has support for
avx2
andfma
. Previously, if a user's CPU didn't support these features, we would still attempt to invoke the LanceDB binaries, which would then cause the entire extension to crash (see #940 #3168).This PR attempts to detect at runtime if a user's CPU has support for both
avx2
andfma
, and if not, we disable indexing to prevent subsequent attempts to invoke the LanceDB binary. The first time this occurs we show a toast warning and link to this PR for context.Checklist
Screenshots
Testing instructions
avx2
andfma
such as Debian Bookworm 12.2 (e.g. Crash after installing continue #3168 (comment))