-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VsCode: Add loading spinner during autocomplete request on current line #3145
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fcd70e3
to
1c84cc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruediste This is super cool! Makes autocomplete feel more predictable. I made a few small adjustments because I think it's really important that this not be too noisy (removed background and underline, and set false by default)
There are two other things I'd probably like to see before merging:
- An animation that feels less noticeable—both the white color and the spinning are a lot of motion. I think that a light gray (HEX #888888) dot that maybe just very slowly pulses would do the trick
- Right now the spinner is flashing a lot when there's a quick completion. I think that we should only show the spinner if ~200ms have passed and the completion is still loading, and probably should show the spinner for a minimum of ~250ms
I added the delay and two icons, now with Synfig Studio, an open source 2D drawing/animation software. I did the dot, but the animation continues running in the background, so some times the dot pops up in it's large state, sometimes in it's small state. So I added a slow spinner as well. To me the spinner looks better. Just replace the Happy to adjust the icons if you have suggestions, I'm not much of a designer ... Just recognized that I only did the delay, not the minimum display time. I'll do this later, time to call it a day. |
# Conflicts: # extensions/vscode/src/autocomplete/completionProvider.ts
The minimum display time is present as well. |
Description
Add loading spinner during autocomplete request on current line. Can be switched off in the vscode extension configuration.
#925
Checklist
Screenshots
Kazam_screencast_00002.mp4
Testing
Edit some code, watch the loading spinner.
Disable the spinner in the settings, validate the absence of the spinner.