Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsCode: Add loading spinner during autocomplete request on current line #3145

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ruediste
Copy link
Contributor

Description

Add loading spinner during autocomplete request on current line. Can be switched off in the vscode extension configuration.

#925

Checklist

  • The relevant docs, if any, have been updated or created

Screenshots

Kazam_screencast_00002.mp4

Testing

Edit some code, watch the loading spinner.
Disable the spinner in the settings, validate the absence of the spinner.

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit b3fa7e1
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/675d4d54cefe2d000822abb8
😎 Deploy Preview https://deploy-preview-3145--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ruediste ruediste force-pushed the autocomplete-spinner branch from fcd70e3 to 1c84cc8 Compare December 4, 2024 06:07
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruediste This is super cool! Makes autocomplete feel more predictable. I made a few small adjustments because I think it's really important that this not be too noisy (removed background and underline, and set false by default)

There are two other things I'd probably like to see before merging:

  • An animation that feels less noticeable—both the white color and the spinning are a lot of motion. I think that a light gray (HEX #888888) dot that maybe just very slowly pulses would do the trick
  • Right now the spinner is flashing a lot when there's a quick completion. I think that we should only show the spinner if ~200ms have passed and the completion is still loading, and probably should show the spinner for a minimum of ~250ms

@ruediste
Copy link
Contributor Author

ruediste commented Dec 10, 2024

I added the delay and two icons, now with Synfig Studio, an open source 2D drawing/animation software. I did the dot, but the animation continues running in the background, so some times the dot pops up in it's large state, sometimes in it's small state. So I added a slow spinner as well. To me the spinner looks better. Just replace the gif files to see both versions.

Happy to adjust the icons if you have suggestions, I'm not much of a designer ...

Just recognized that I only did the delay, not the minimum display time. I'll do this later, time to call it a day.

# Conflicts:
#	extensions/vscode/src/autocomplete/completionProvider.ts
@ruediste
Copy link
Contributor Author

The minimum display time is present as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants