Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typos related to voyage AI #1694

Closed
wants to merge 1 commit into from
Closed

Conversation

Laxenade
Copy link

@Laxenade Laxenade commented Jul 9, 2024

Description

Fixing a few typos on Voyage AI being used with the wrong provider. I couldn't find any usage in code where the provider is used/validated when the model "voyage-code-2" is being configured. Feel free to close this issue if you don't think it's important enough.

This addresses: #1693

Checklist

  • The base branch of this PR is dev, rather than main
  • The relevant docs, if any, have been updated or created

Screenshots

N/A

Testing

N/A

@sestinj
Copy link
Contributor

sestinj commented Jul 9, 2024

@Laxenade thanks for helping out here! These are actually correct—we use "provider" to indicate the format of the API call, which in Voyage's case is the same as OpenAI, hence the "openai" provider with custom "apiBase". I don't think you're wrong though that this is confusing. What would probably be a good outcome here would be making a dedicated Voyage AI embeddings provider.

Closing this for now, but if you would have interest in contributing this, let me know!

@sestinj sestinj closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants