Add DataContainerConfigOptionToParameterRector

[zoglo]

Description

• Implements Rewrite DCA image extensions config to parameter #3

Old:

'screenshot' => [
    'exclude' => true,
    'inputType' => 'fileTree',
    'eval' => ['fieldType'=>'radio', 'filesOnly'=>true, 'isGallery'=>true, 'extensions'=>Contao\Config::get('validImageTypes')],
    'sql' => "binary(16) NULL"
],

New:

'screenshot' => [
    'exclude' => true,
    'inputType' => 'fileTree',
    'eval' => ['fieldType'=>'radio', 'filesOnly'=>true, 'isGallery'=>true, 'extensions'=>'%contao.image.valid_extensions%'],
    'sql' => "binary(16) NULL"
],

Test

[aschempp]

I'm not sure this is correct. We can only replace the config option with a parameter where it is expected to work, e.g. in the DCA config. If my custom code retrieves this value, we cannot replace this with a string, it would break everything?

[zoglo]

Same as #8 (comment) - Might need to limit it to specific arrays and entry types (array keys) to change the value.

[zoglo]

@aschempp This one is even more specific now and checks if it's in an array with key an eval, then checks the extensions and whether the static call is the Contao\Config::class with method get to replace it

Could do the same for #6 if we want it even more specific as well 🤔

[zoglo]

Will be implemented in #6