fix(matrix): add missing txid to send message call #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 79.12% 79.24% +0.11%
==========================================
Files 102 102
Lines 4488 4480 -8
==========================================
- Hits 3551 3550 -1
+ Misses 758 752 -6
+ Partials 179 178 -1 ☔ View full report in Codecov by Sentry. |
piksel
force-pushed
the
fix/matrix-txid
branch
from
79d6d40
to
fe44270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Matrix Client/Server spec requires that the send message endpoint includes a unique transaction id with each request. The matrix service omits this id for some reason, and the original testing server probably allowed this.
This PR adds an incrementing counter as the transaction ID, which should allow it to work with conduit matrix server.
Fixes #415.