Some debian test fixes #24861
Open
Some debian test fixes #24861
+47
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found in debian testing where by default there are no unqualified search registries installed. As such the test failed as the FIXME said. Now there is no need for the test to assume anything. Instead set our own config via CONTAINERS_REGISTRIES_CONF then we can do exact matches, except that env was not read in the shell completion code so move some code around to make it read the var in the same way as podman login/logout. Signed-off-by: Paul Holzinger <[email protected]>
This test a pretty much useless, it checks that a connection attempt on the default socket fails. But this is incorrect as the socket is outside of the test control as such it might be ready to accept connections as thus the test can fail locally or as reported here in the debian tests. Given that a simple connection fails does not add any value I opted to remove it. Fixes containers#24803 Signed-off-by: Paul Holzinger <[email protected]>
If the source dir is owned by another user then the test the chown will fail assuming we run the tests rootless. This function is only used by the quadlet tests and for the purpose all we need is to read the files so the simple fix is remove the chown as this should make the tests pass on the special debian gating env. Fixes containers#24802 Signed-off-by: Paul Holzinger <[email protected]>
When running this test on a system without unqualifiedsearch registries it will fail with a different error causing the test to fail. to avoid that case define our own registries.conf that defines quay.io as registry. This should make the test pass in the debian env. Signed-off-by: Paul Holzinger <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits, a few fixes to make the test work in the default debian package environment
Does this PR introduce a user-facing change?