fix(quadlet): parse comment lines with kv-pairs #24719
Conversation
Fixes a bug in the quadlet unitfile parser that is triggered by an commented multi-line assignment line, e.g. by a line " #=\" in unit file. The bug caused an infinite loop of the quadlet unit generator. Signed-off-by: Jasper Wiegratz <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jwhb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Thanks for the PR but all development must go into the main branch first.
The PR is against the v4.9.4-rhel branch. For that to merge, we need an issue/bug against RHEL.
I don't see such a commit anywhere in main. Only then we can consider backporting. And as @vrothberg mentions that requires RHEL bugs and must go through the proper RHEL process so we cannot accept this in its current form.
And also add test files to confirm your new changes, i.e. see test/e2e/quadlet_test.go
Does this PR introduce a user-facing change?
None