Update config.py #439
Update config.py #439
Conversation
|
|
||
| from podman.api import cached_property | ||
| from podman.api.path_utils import get_xdg_config_home | ||
| from podman import PodmanClient |
There was a problem hiding this comment.
This line is giving a circular import. Please, remove it. There are ways to call the client such as podman_client = self.client
| """ | ||
| try: | ||
| # Initialize Podman client | ||
| podman_client = PodmanClient(base_url="unix://run/podman/io.podman") |
There was a problem hiding this comment.
This line relates to the fix above
| if __name__ == "__main__": | ||
| try: | ||
| # Define container parameters | ||
| network_name = "pasta" # Replace with your network name if different | ||
| port_mapping = "3128:3128" # Host port : Container port | ||
| image = "your-image" # Replace with your actual image | ||
| container_name = "your-container" # Replace with your desired container name | ||
|
|
||
| # Additional parameters (if any) | ||
| additional_kwargs = { | ||
| # Example: Environment variables | ||
| # "environment": {"ENV_VAR": "value"}, | ||
| # Example: Volume mounts | ||
| # "volumes": {"/host/path": {"bind": "/container/path", "mode": "rw"}}, | ||
| } | ||
|
|
||
| # Create and start the container | ||
| container = create_container_with_pasta( | ||
| network_name=network_name, | ||
| port_mapping=port_mapping, | ||
| image=image, | ||
| container_name=container_name, | ||
| **additional_kwargs | ||
| ) | ||
|
|
||
| print(f"Container '{container.name}' is running with TCP namespace forwarding from host port {port_mapping.split(':')[0]} to container port {port_mapping.split(':')[1]}.") | ||
|
|
||
| except Exception as e: | ||
| print(f"Failed to create and start container: {e}") |
There was a problem hiding this comment.
I am perplexed about the if __name__ == "__main__": block. What would be it's use case?
There are circular imports failures related to it, so I would remove it. The example looks nice though so actually it could be documented.
|
@kajal072001 any update on this pr? |
|
@kajal072001 any update on my comments? :) |
There was a problem hiding this comment.
This doesn't look right or useful to me. Containers.conf should be parsed on the server never the client.
There a few exceptions (mainly connections) but everything else should already be read by the podman service. Beside also the config file parsing here be wrong anyway.
I don't think this PR is addressing the raised issue so I don't think it makes sense
| network_config = self.attrs.get("network", {}) | ||
| for network_name, config in network_config.items(): | ||
| # Assuming network options are stored as 'pasta_options', 'bridge_options', etc. | ||
| options_key = f"{network_name}_options" | ||
| if options_key in network_config: | ||
| network_opts[network_name] = network_config[options_key] |
There was a problem hiding this comment.
besides pasta_options none of the other fields exists in containers.conf so it should not invent anything.
| # Append the port mapping using '-T' flag | ||
| network_opts += ["-T", port_mapping] | ||
| logging.debug(f"Updated network options for '{network_name}': {network_opts}") |
There was a problem hiding this comment.
This looks wrong, -T maps container ports to the host and you allow only one string. Overall I don't follow this at all.
| return network_opts | ||
|
|
||
|
|
||
| def create_container_with_pasta(network_name: str, port_mapping: str, image: str, container_name: str, **kwargs): |
There was a problem hiding this comment.
There is nothing special about pasta API wise, all the networks settings should be able to be set already via the normal API.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kajal072001 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addressing #438
Changes
Integrate Configuration Management:
Use the enhanced
PodmanConfigclass to dynamically retrieve and apply network options fromcontainers.conf.Utilize Detailed Logging:
Configure logging to capture detailed information for debugging purposes.
Validate Network Driver Support:
Confirm that the Pasta network driver supports the
-Toption and handles port mappings as expected.