Ensure the fd will be release completely #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifupan
reviewed
Apr 29, 2024
lifupan
approved these changes
Apr 29, 2024
Tim-Zhang
reviewed
Apr 29, 2024
|
@jokemanfire Good catch, thanks and just left a format recommendation. |
This problem is caused by the reference count not being able to return to 0 properly. Signed-off-by: jokemanfire <[email protected]>
Tim-Zhang
added a commit
to Tim-Zhang/ttrpc-rust
that referenced
this pull request
Sep 24, 2024
It should be a mistake to modify it from -1 to 10 in the PR containerd#226 https://github.com/containerd/ttrpc-rust/pull/226/files#diff-e74ddb472174f24fb4713f5a2fe2d33bbc5db28ee2a5c7dad1ea9025b897e8a5R110 There already are monitor_fd to notify exit, so accept without timeout is safe. Signed-off-by: Tim Zhang <[email protected]>
jokemanfire
pushed a commit
to jokemanfire/ttrpc-rust
that referenced
this pull request
Sep 27, 2024
It should be a mistake to modify it from -1 to 10 in the PR containerd#226 https://github.com/containerd/ttrpc-rust/pull/226/files#diff-e74ddb472174f24fb4713f5a2fe2d33bbc5db28ee2a5c7dad1ea9025b897e8a5R110 There already are monitor_fd to notify exit, so accept without timeout is safe. Signed-off-by: Tim Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the 'fd' is not release completely