Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android build #224

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix android build #224

merged 1 commit into from
May 6, 2024

Conversation

powturns
Copy link
Contributor

@powturns powturns commented Apr 1, 2024

Android target fails to compile as fd is not defined.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.97%. Comparing base (486b4e8) to head (a9198f2).
Report is 1 commits behind head on master.

❗ Current head a9198f2 differs from pull request most recent head b5cbdcc. Consider uploading reports for the commit b5cbdcc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   24.97%   24.97%           
=======================================
  Files          16       16           
  Lines        2651     2651           
=======================================
  Hits          662      662           
  Misses       1989     1989           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsturtevant
Copy link
Collaborator

LGTM

needs #223 before this will be green @Tim-Zhang @wllenyj

@wllenyj
Copy link
Collaborator

wllenyj commented Apr 8, 2024

do a rebase?

Ensure fd variable are defined on android

Signed-off-by: Dustin Thomson <[email protected]>
@wllenyj
Copy link
Collaborator

wllenyj commented Apr 28, 2024

maybe tokens is required by coverage CI.

[2024-04-28T01:57:21.081Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 1322 seconds.', code='throttled')}

@wllenyj wllenyj merged commit 6cf4d5b into containerd:master May 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants