store: use Forgotten() for lifetime management with leveraging Initialized() for readiness check #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
force-pushed
the
inorelease-l-forked
branch
from
9ad39ea
to
62e9b99
Compare
ktock
changed the title
…lized() Signed-off-by: Kohei Tokunaga <[email protected]>
ktock
force-pushed
the
inorelease-l-forked
branch
from
62e9b99
to
72418a3
Compare
ktock
changed the title
AkihiroSuda
reviewed
Jun 19, 2024
| @@ -144,3 +144,5 @@ replace ( | |||
| github.com/containerd/stargz-snapshotter/estargz => ../estargz | |||
| github.com/containerd/stargz-snapshotter/ipfs => ../ipfs | |||
| ) | |||
|
|
|||
| replace github.com/hanwen/go-fuse/v2 => github.com/ktock/go-fuse/v2 v2.1.1-0.20240611080711-f59a74eb644a | |||
There was a problem hiding this comment.
Yes, there is a PR for this: hanwen/go-fuse#520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1599
Fixes: #1594
Thanks to @iain-macdonald 's patch for go-fuse (hanwen/go-fuse#520), we can rely on Inode.Forgotten to check if that inode is reusable or not. This commit cherry-picks @iain-macdonald's patch to ktock/go-fuse@f59a74e and imports to stargz-snapshotter. That patch adds
Initialized()method that can be used for checking the readiness of Forgotten() metehod and we can avoid the issues like hanwen/go-fuse#504 and #1594 .