[WIP] add ignoreRedirect flag in p2pConfig to skip redirect #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigVan
reviewed
Apr 29, 2024
| if (actual_info->mode == UrlMode::Redirect) | ||
| actual_url = actual_info->info.data(); | ||
| } | ||
|
|
There was a problem hiding this comment.
getActualUrl() will get the 'Bearer Token' and put it to HTTP Header, see
https://github.com/containerd/overlaybd/blob/main/src/overlaybd/registryfs/registryfs.cpp#L145
If ignoreRedirect is true,
overlaybd will send the request URL to Kraken listened port without any authentication ? is this what you want?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a draft PR to demonstrate a potential solution for #326
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: