Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] turboOCI commit with uuid #269

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

WaberZhuang
Copy link
Contributor

@WaberZhuang WaberZhuang commented Sep 22, 2023

What this PR does / why we need it:
UUID is missed when using overlaybd-commit with the option --uuid and --turboOCI, instead of a random uuid in the committed file. After this fix, we can reproduce turboOCI files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@BigVan
Copy link
Member

BigVan commented Sep 22, 2023

please add a UT to check the UUID if empty when creating a new LSMTFile

Signed-off-by: zhuangbowei.zbw <[email protected]>
@WaberZhuang
Copy link
Contributor Author

please add a UT to check the UUID if empty when creating a new LSMTFile

Added. With the unit tests, I checked the following cases:

  • LSMTFile is created with a random non-empty UUID
  • This UUID will be empty after committing without specifying CommitArgs.uuid
  • This UUID will be a specific UUID after committing with specific CommitArgs.uuid

@BigVan
Copy link
Member

BigVan commented Sep 26, 2023

LGTM

@BigVan BigVan merged commit 970dbb3 into containerd:main Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants