deduplicate creating enum values in data providers

consistence · Feb 22, 2023 · 8d4f5b1 · 8d4f5b1
1 parent 933dfd6
commit 8d4f5b1
Showing 1 changed file with 30 additions and 33 deletions.
diff --git a/tests/Enum/Type/EnumTypeIntegrationTest.php b/tests/Enum/Type/EnumTypeIntegrationTest.php
@@ -16,30 +16,44 @@ class EnumTypeIntegrationTest extends \PHPUnit\Framework\TestCase
 	/**
 	 * @return mixed[][]|\Generator
 	 */
-	public function convertEnumToDatabaseDataProvider(): Generator
+	public function enumDataProvider(): Generator
 	{
 		yield 'float enum' => [
 			'type' => DoctrineType::getType(FloatEnumType::NAME),
 			'enum' => FooFloatEnum::get(FooFloatEnum::ONE),
-			'expectedValue' => FooFloatEnum::ONE,
+			'scalarValue' => FooFloatEnum::ONE,
 		];
 		yield 'integer enum' => [
 			'type' => DoctrineType::getType(IntegerEnumType::NAME),
 			'enum' => FooIntegerEnum::get(FooIntegerEnum::ONE),
-			'expectedValue' => FooIntegerEnum::ONE,
+			'scalarValue' => FooIntegerEnum::ONE,
 		];
 		yield 'string enum' => [
 			'type' => DoctrineType::getType(StringEnumType::NAME),
 			'enum' => FooStringEnum::get(FooStringEnum::ONE),
-			'expectedValue' => FooStringEnum::ONE,
+			'scalarValue' => FooStringEnum::ONE,
 		];
 		yield 'boolean enum' => [
 			'type' => DoctrineType::getType(BooleanEnumType::NAME),
 			'enum' => FooBooleanEnum::get(FooBooleanEnum::ENABLED),
-			'expectedValue' => FooBooleanEnum::ENABLED,
+			'scalarValue' => FooBooleanEnum::ENABLED,
 		];
 	}
 
+	/**
+	 * @return mixed[][]|\Generator
+	 */
+	public function convertEnumToDatabaseDataProvider(): Generator
+	{
+		foreach ($this->enumDataProvider() as $name => $values) {
+			yield $name => [
+				'type' => $values['type'],
+				'enum' => $values['enum'],
+				'expectedValue' => $values['scalarValue'],
+			];
+		}
+	}
+
 	/**
 	 * @dataProvider convertEnumToDatabaseDataProvider
 	 *
@@ -58,18 +72,11 @@ public function testConvertEnumToDatabase(DoctrineType $type, Enum $enum, $expec
 	 */
 	public function enumTypesDataProvider(): Generator
 	{
-		yield 'float enum' => [
-			'type' => DoctrineType::getType(FloatEnumType::NAME),
-		];
-		yield 'integer enum' => [
-			'type' => DoctrineType::getType(IntegerEnumType::NAME),
-		];
-		yield 'string enum' => [
-			'type' => DoctrineType::getType(StringEnumType::NAME),
-		];
-		yield 'boolean enum' => [
-			'type' => DoctrineType::getType(BooleanEnumType::NAME),
-		];
+		foreach ($this->enumDataProvider() as $name => $values) {
+			yield $name => [
+				'type' => $values['type'],
+			];
+		}
 	}
 
 	/**
@@ -88,22 +95,12 @@ public function testConvertNullToDatabase(DoctrineType $type): void
 	 */
 	public function convertScalarValueToDatabaseDataProvider(): Generator
 	{
-		yield 'float enum' => [
-			'type' => DoctrineType::getType(FloatEnumType::NAME),
-			'scalarValue' => FooFloatEnum::ONE,
-		];
-		yield 'integer enum' => [
-			'type' => DoctrineType::getType(IntegerEnumType::NAME),
-			'scalarValue' => FooIntegerEnum::ONE,
-		];
-		yield 'string enum' => [
-			'type' => DoctrineType::getType(StringEnumType::NAME),
-			'scalarValue' => FooStringEnum::ONE,
-		];
-		yield 'boolean enum' => [
-			'type' => DoctrineType::getType(BooleanEnumType::NAME),
-			'scalarValue' => FooBooleanEnum::ENABLED,
-		];
+		foreach ($this->enumDataProvider() as $name => $values) {
+			yield $name => [
+				'type' => $values['type'],
+				'scalarValue' => $values['scalarValue'],
+			];
+		}
 	}
 
 	/**