[KIP-714] Fix to avoid sending a NULL metrics payload #4912
+38
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when no metrics are matching, client side, a NULL metrics payload must not be sent, because it's not accepted by the protocol and it causes a disconnection by the broker.
An empty payload must be sent instead.
There are some additional checks on the mock implementation to match the broker one, so the test 0150
is failing with first commit.
The fix returns NULL only in the serialization error case and it's not sending a Push in that case, while it returns an empty buffer when there are zero metrics to send.