Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIP-714] Fix to avoid sending a NULL metrics payload #4912

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Nov 22, 2024

when no metrics are matching, client side, a NULL metrics payload must not be sent, because it's not accepted by the protocol and it causes a disconnection by the broker.
An empty payload must be sent instead.

There are some additional checks on the mock implementation to match the broker one, so the test 0150

                do_test_telemetry_empty_subscriptions_list(
                    type, "non-existent-metric");

is failing with first commit.

The fix returns NULL only in the serialization error case and it's not sending a Push in that case, while it returns an empty buffer when there are zero metrics to send.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant