Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[grafana]: scripting dashboards #82

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

jeqo
Copy link
Contributor

@jeqo jeqo commented Jul 12, 2022

Major change to manage grafana dashboards via scripts, using grafanalib.

Changes:

  • New directory for dashboard scripts: ./grafana-dashboards

  • Script to generate dashboards for VM/cp-demo deployments and CFK deployments: ./grafana-dashboards/Makefile

  • Updated dashboards:

  • Dashboards:

    • Kafka Cluster:
      • Remove "Broker network throughput" panel, and use it for specific metrics

image

image

- Move Zookeeper related metrics to Zookeeper cluster dashboard 
- Throughput panels that sum all brokers are removed, as that can be inferred from throughput per brokers, or tweaked by stacking the results per broker: 

image

image

- Request rates put together in one timeseries:

image

image

  • Kafka Connect cluster:
    • Redesign the general group, removing pie-charts and showing table with all details instead, also moved rebalancing up in the dashboard:

image

image

- Mixed related metrics in the same panel: e.g. commit success and failure % are now in the same panel
  • Kafka Topics:
    • Removed the topic/partition stat as it is on the kafka cluster
    • Merged offset tables into 1

image

  • ksqlDB:
    • Reduced stats on the top to show more in less space:

image

image

@waliaabhishek
Copy link
Member

Kafka Consumer dashboard -- Added 32 new panels. Awesome work here.
Original had 19 expr statements.
New has 51 expr statements.

Kafka Producer dashboard -- Added 10 new panels. Awesome work here.
Original had 32 expr statements.
New has 42 expr statements.

We are missing some graphs on the newly generated json files:

Kafka Cluster dashboard -- Missing 16 panels
Original had 70 expr statements.
New has 54 expr statements.

Kafka Connect dashboard -- Missing 22 panels
Original had 74 expr statements.
New has 52 expr statements.

Kafka Topics dashboard -- Missing 2 panels
Original had 10 expr statements.
New has 8 expr statements.

KSQLDB dashboard -- Missing 5 panels
Original had 39 expr statements.
New has 34 expr statements.

SR dashboard -- Missing 4 panels
Original had 12 expr statements.
New has 8 expr statements.

@waliaabhishek
Copy link
Member

The CFK new commit looks awesome. Thanks for the new add.

@jeqo
Copy link
Contributor Author

jeqo commented Aug 3, 2022

@waliaabhishek thanks for the review!
I have added panel changes to the description with some of the reasoning behind removing/merging/moving some panels, also fix a few based on your feedback.
Let me know how it looks now.

@cla-assistant
Copy link

cla-assistant bot commented Aug 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hifly81 hifly81 changed the base branch from 7.2-post to main August 10, 2023 12:05
@hifly81
Copy link
Contributor

hifly81 commented Nov 14, 2024

The PR is now diverging too much from main and it is difficult to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants