Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align plugin versions for modules not depending on common #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xvrl
Copy link
Member

@xvrl xvrl commented Jun 5, 2020

In #265 we had to downgrade plugins due to inconsistent versions being used across different modules. This upgrades deploy and install plugins in all our modules, including which do not inherit from common pom.

This should allow us to switch to the new syntax for alt*DeploymentRepository to workaround authentication issues with the deprecated syntax. (see https://issues.apache.org/jira/browse/MDEPLOY-246)

@xvrl xvrl requested a review from ewencp June 5, 2020 06:15
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch looks fine, but i haven't looked into the CI build failure. one thing to keep in mind is testing. we could do muckrake or packaging test, but this potentially has broader fallout, e.g. connectors. some stuff might not use this, but just want to be careful since a change here can affect so many repos

@xvrl xvrl force-pushed the upgrade-non-common-poms branch from 34a634b to f6920f0 Compare June 5, 2020 17:44
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should still get a green build. @xvrl the most recent failure is in a downstream build and seems like probably something else was just broken at the time, probably just retriggering would resolve.

@xvrl
Copy link
Member Author

xvrl commented Jun 18, 2020

@ewencp sounds good. Before we merge I'd like to have @gracechensd approve, since this will cause the build to fail once merged until we switch to the new property syntax.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants