[WIP] Refactoring on Source Parsing Related Functions from #316 #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
srilman
changed the title
maresb
reviewed
Feb 10, 2023
| @@ -357,6 +312,7 @@ def make_lock_files( | |||
| platform_overrides=platform_overrides, | |||
| virtual_package_repo=virtual_package_repo, | |||
| required_categories=required_categories if filter_categories else None, | |||
| pip_support=PIP_SUPPORT, | |||
There was a problem hiding this comment.
Hmm, is this based on before or after #340?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is just the first 2 commits of #316, split into a new PR and rebased against main. This is because these 2 commits only perform the following:
make_lock_specandparse_source_filesfunctions fromconda_lock.pytosrc_parser/__init__.pyparse_pyproject_tomlfunction to the end ofpyproject_toml.py