Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code-editor version to 1.2.0 #26

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

navinsoni
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

conda-forge-curator bot and others added 4 commits May 14, 2024 19:30
* Change build target to dev build

**Description**

Change build target to dev build to create a dev branch for rapid testing

* Update SHA for CodeEditor1.0.1

**Description**

Update SHA for CodeEditor1.0.1

**Motivation**

SHA was not updated, caused build to fail. Fixing here to match commit ad7322c

* add aws-pangestu as contributor (conda-forge#19)

**Description**

- add aws-pangestu as contributor

---------

Co-authored-by: Jed A <[email protected]>
**Description**

Pin nodejs to 18.18.2 for compatibility with sagemaker-distribution 1.5.3 and 1.4.4
Co-authored-by: Navin Soni <[email protected]>

Changes for pulling vscode 1.90.1 to update node version >=20.9
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants