Recipe update for pulling vscode 1.90.1; fixing build failure #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** Change build target to dev build to create a dev branch for rapid testing
**Description** Update SHA for CodeEditor1.0.1 **Motivation** SHA was not updated, caused build to fail. Fixing here to match commit ad7322c
**Description** - add aws-pangestu as contributor
**Description** Pin nodejs to 18.18.2 for compatibility with sagemaker-distribution 1.5.3 and 1.4.4
**Description** Recipe update for pulling vscode 1.90.1. CodeEditor updates includes the resolutions for merge conflicts from the pull **Motivation** Need to update node version **Testing Done** manual testing
build was failing due to missing new line at eof
update sha with new version that fixes the file structure of the tar
…nda-forge-pinning 2024.06.20.18.47.46
points to source that removes git actions in postinstall
**Description** * Add DISABLE_V8_COMPILE_CACHE flag to fix build failure **Motivation** * Seeing error below while building package with nodejs 20: ``` Error: Command failed: yarn list --prod --json Fatal error in , line 0 Check failed: current == end_slot_index. ``` * Per recommendation in nodejs/node#51555, setting this flag **Testing Done** * Dry-run building this package after setting this flag. The error no longer shows up. **Backwards Compatibility Criteria (if any)** * N/A
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
zuoyuanh
changed the title
|
The issue is likely related to However the build failed in the last step due to overlinking error. |
**Description** * Disable conda_build.error_overlinking * Update build number to 0 **Motivation** * We are seeing build failures due to overlinking issues * Per investigation in conda-forge/jupyter_scheduler-feedstock#5, we concluded the overlinking check is mainly used to encourge better management of shared libraries to minimize resource use, but is ultimately necessary. The error has also shown up in multiple other pkgs that uses C libs including python and numpy. **Testing Done** * Confirmed package build is successful locally after making this change **Backwards Compatibility Criteria (if any)** * N/A
|
Per investigation in conda-forge/jupyter_scheduler-feedstock#5, we concluded the overlinking check is mainly used to encourge better management of shared libraries to minimize resource use, but is ultimately necessary. The error has also shown up in multiple other pkgs that uses C libs including Added a commit to disable |
zuoyuanh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw build failure in conda-forge after pulling in vscode 1.90.1 after upgrading to nodejs 20.x. Error message:
Opening this PR to pull in vscode 1.90.1 and fix the related build failure.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)