Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libboost 1.86 #62

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libboost186.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10430005087 - please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Hm, it seems like lightgbm is vendoring boost (c.f. $SRC_DIR/external_libs/compute/include/boost)? Probably that version is incompatible with 1.86:

  In file included from $SRC_DIR/external_libs/compute/include/boost/compute/program.hpp:35,
                   from $SRC_DIR/external_libs/compute/include/boost/compute/kernel.hpp:24,
                   from $SRC_DIR/external_libs/compute/include/boost/compute/memory_object.hpp:16,
                   from $SRC_DIR/external_libs/compute/include/boost/compute/buffer.hpp:17:
  $SRC_DIR/external_libs/compute/include/boost/compute/detail/sha1.hpp: In member function 'boost::compute::detail::sha1::operator std::string()':
  $SRC_DIR/external_libs/compute/include/boost/compute/detail/sha1.hpp:41:26: error: cannot convert 'unsigned int [5]' to 'unsigned char (&)[20]'
     41 |             h.get_digest(digest);
        |                          ^~~~~~
        |                          |
        |                          unsigned int [5]

@StrikerRUS
Copy link
Contributor

Might be related: microsoft/LightGBM#6582.

Probably that version is incompatible with 1.86:

boostorg/compute hasn't been updated since Sep 23, 2021. They just bump tag versions. Vendored commit is the most recent one.

@bennibbelink
Copy link

We're experiencing a similar issue in conda-forge/cyclus-feedstock#83. It looks like boostorg/uuid has been updated in version 1.86.0 to define digest_type as char[20] (changed from unsigned int[5] in version 1.85.0). Hope this helps.

@regro-cf-autotick-bot
Copy link
Contributor Author

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/10834285947 - please use this URL for debugging,

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libboost186-0-1_h92777c branch September 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants