Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge fmt #29

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Forge fmt #29

merged 4 commits into from
Oct 20, 2023

Conversation

cwang25
Copy link
Contributor

@cwang25 cwang25 commented Oct 19, 2023

  • Add forge fmt --check to action
  • All changes are done by forge fmt

@scott-silver
Copy link
Contributor

Add forge fmt --check to action

I added forge fmt --check to the Github Action that runs the unit tests, so now CI should fail if we have non-compliant code

@cwang25
Copy link
Contributor Author

cwang25 commented Oct 19, 2023

I purposely put it into lint.yml as a separate CI flows. So it's easier to see if it's failing at lint or failing at test

Before PR merge the workflow won't show (sadly that's how github works :( )
But once merged the lint.yml should appear as separate checks in PR interface.

I sort of prefer to have two checks in interface one lint one test How do you think?

@scott-silver
Copy link
Contributor

that's fine with me, but I don't think lint.yml made it into this PR

@cwang25
Copy link
Contributor Author

cwang25 commented Oct 20, 2023

Screen Shot 2023-10-19 at 5 07 31 PM

@cwang25 cwang25 merged commit 22c274b into main Oct 20, 2023
2 checks passed
@cwang25 cwang25 deleted the hans/forge-fmt branch October 20, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants