Use bytes for signature instead of v,r,s #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
changed the title
kevincheng96
force-pushed
the
kevin/remove-vrs
branch
from
419119d
to
f5502a5
Compare
kevincheng96
requested review from
hayesgm and
fluffywaffles
and removed request for
hayesgm
kevincheng96
force-pushed
the
kevin/delegatecall
branch
from
bffc5ee
to
8e664aa
Compare
kevincheng96
force-pushed
the
kevin/remove-vrs
branch
from
cea6a75
to
aca7392
Compare
fluffywaffles
approved these changes
Oct 15, 2024
| @@ -448,7 +409,8 @@ contract QuarkWallet is IERC1271 { | |||
| revert InvalidEIP1271Signature(); | |||
| } | |||
| } else { | |||
| (address recoveredSigner, ECDSA.RecoverError recoverError) = ECDSA.tryRecover(digest, v, r, s); | |||
| // For EOA signers, this implementation of the QuarkWallet only supports ECDSA signatures | |||
| (address recoveredSigner, ECDSA.RecoverError recoverError) = ECDSA.tryRecover(digest, signature); | |||
There was a problem hiding this comment.
oh nice, OZ did the decoding for us 👍
hayesgm
approved these changes
Oct 15, 2024
kevincheng96
force-pushed
the
kevin/delegatecall
branch
from
8e664aa
to
09f8e8d
Compare
kevincheng96
force-pushed
the
kevin/remove-vrs
branch
from
aca7392
to
b3badc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuarkWalletscurrently takev,r,sas inputs for the ECDSA signature. This limits the wallet to only support ECDSA signatures, even if thesignerof the wallet is a EIP-1271 smart contract that supports other signature schemes (e.g. BLS, Passkey). To make the wallet more flexible and be able to support other signature schemes, we change the signature input to a genericbytestype.Note: This only increases flexibility for Quark wallets that have an EIP-1271 contract as a signer, where the EIP-1271 contract is upgradeable. Quark wallets owned by EOA signers will still need to be migrated over to a new wallet implementation in order to support other types of signature schemes.
Gas impact: Seems like this change bumps up gas usage by 900-1k (negligible). This is likely because the wallet now needs to take the extra step of decoding
bytes signatureintov,r,s. The tests that fail the gas snapshot are all ones that runexecuteQuarkOperationmultiple times, exceeding the gas diff tolerance.