replace _spendEncumbrance with _releaseEncumbrance #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Coburn is back from leave, revisiting the third encumbrance event.
This approach is an alternative to the
EncumbranceSpend
event from #25. Coburn has pointed out that the logic of_release
and_spendEncumbrance
are nearly identical.This patch merges the two functions (renamed to
_releaseEncumbrance
). This means that when you spend an encumbrance, aRelease
event is emitted.If you want to track an address's encumbrance, you can do so by reading
Encumber
andRelease
amounts. If you want to track their balance, you can do so by readingMint
,Transfer
andBurn
amounts.