Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional events #17

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Additional events #17

merged 2 commits into from
Jul 20, 2023

Conversation

scott-silver
Copy link
Collaborator

L-03 Lack of Event Emission

@scott-silver scott-silver changed the title Silver/additional events Additional events Jul 17, 2023
kevincheng96
kevincheng96 reviewed Jul 18, 2023
View reviewed changes
src/EncumberableToken.sol Outdated Show resolved Hide resolved
src/EncumberableTokenFactory.sol Outdated Show resolved Hide resolved
test/EncumberableTokenFactory.t.sol Outdated Show resolved Hide resolved
kevincheng96
kevincheng96 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor comment on the natspec.

@scott-silver scott-silver merged commit e302118 into main Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincheng96 kevincheng96 kevincheng96 approved these changes

@mykelp mykelp Awaiting requested review from mykelp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scott-silver @kevincheng96