Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-audit updates #10

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Pre-audit updates #10

merged 3 commits into from
Jun 30, 2023

Conversation

scott-silver
Copy link
Collaborator

@scott-silver scott-silver commented Jun 30, 2023 •
edited by kevincheng96
Loading

working through some pre-audit feedback:

Non-explicit imports are used

State variable visibility not explicitly declared

Missing docstrings

Unused import

Using int/uint instead of int256/uint256

Constant not using UPPER_CASE format

kevincheng96
kevincheng96 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thoughts on moving towards non-explicit imports?

@scott-silver
Copy link
Collaborator Author

Thoughts on moving towards non-explicit imports?

I don't have strong feelings about them. I suppose it would be an improvement to be explicit about what we're importing.

@scott-silver
Copy link
Collaborator Author

updated to use explicit imports.

the only import that i was unable to convert to an explicit import is import "forge-std/StdUtils.sol";, which we use to import Forge's ERC20 deal function

kevincheng96
kevincheng96 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@scott-silver scott-silver merged commit 6e00218 into main Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincheng96 kevincheng96 kevincheng96 approved these changes

@mykelp mykelp Awaiting requested review from mykelp

@coburncoburn coburncoburn Awaiting requested review from coburncoburn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scott-silver @kevincheng96