-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float32 Testing #414
Merged
Merged
Float32 Testing #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
Performance Ratio:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current approach to testing with Float32 is non-existent -- we just assume that all rules work correctly for both provided that we've tested on Float64. This is probably fine (albeit somewhat scary) when the only difference between the F64 and F32 rule is a type parameter, as has been the case so far. I will shortly be adding a lot of GPU rules, for which Float64 rules might not be provided. Consequently, it is about to become important that we have the ability to properly test the correctness of rules involving Float32s.
This PR adds this. The existing functionality is basically fine, it's looking like I just need to
I'm now going through my test suite, adding for-loops in various places to ensure that both Float64 and Float32 are tested.
update: this is nearly there now. A few bugs (not numerical correctness issues happily) were uncovered as I went through and started to add in Float32 tests everywhere. It looks like a memory-related bug has been revealed in the LAPACK rules, so I'll need to resolve that before merging.