Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bijectors.jl #357

Closed
wants to merge 1 commit into from
Closed

Update bijectors.jl #357

wants to merge 1 commit into from

Conversation

yebai
Copy link
Contributor

@yebai yebai commented Nov 8, 2024

Seems that #319 is now fixed.

EDIT: no, it is not.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │     70.9 │     1.0 │        5.51 │ missing │
│                  _sum_1000 │     6.78 │  1600.0 │        33.6 │ missing │
│               sum_sin_1000 │      2.3 │    1.68 │        10.6 │ missing │
│              _sum_sin_1000 │     2.66 │   209.0 │        13.4 │ missing │
│                   kron_sum │     85.8 │    5.25 │       294.0 │ missing │
│              kron_view_sum │     60.2 │    9.39 │       248.0 │ missing │
│      naive_map_sin_cos_exp │     2.51 │ missing │        7.07 │ missing │
│            map_sin_cos_exp │     2.44 │    1.29 │        5.53 │ missing │
│      broadcast_sin_cos_exp │     2.53 │    3.56 │        1.43 │ missing │
│                 simple_mlp │     2.93 │    3.08 │        6.41 │ missing │
│                     gp_lml │     3.23 │    1.65 │     missing │ missing │
│ turing_broadcast_benchmark │     3.13 │ missing │        25.8 │ missing │
│         large_single_block │     4.01 │  4090.0 │        30.3 │ missing │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt
Copy link
Member

@yebai can we close this, since the problem isn't addressed?

@yebai yebai closed this Nov 8, 2024
@yebai yebai deleted the yebai-patch-1 branch November 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants