Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yebai this PR adds some basic Lux integration testing. There are some test failures at the minute that I'll patch up -- they'll just be intrinsics + rules etc I imagine.
@avik-pal I've just copied over the Enzyme tests that you pointed us towards, and am converting everything to
Float64
(because that's what our testing infrastructure is best equipped to handle at the minute). If you could let me know if anything looks obviously wrong in how I'm making use of the tests, that would be great!Update: the current failures are all rule-related. I think we basically just need to work through NNlib.jl and make sure that everything there works.