Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Safe Rule #150

Merged
merged 2 commits into from
May 14, 2024
Merged

Verify Safe Rule #150

merged 2 commits into from
May 14, 2024

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented May 14, 2024

I wasn't checking that safe mode can be used with value_and_pullback!! etc. Fortunately, DifferentiationInterface's CI caught the problem. This PR fixes the problem, and ensures that tests are run in safe mode.

Copy link
Contributor

Performance Ratio:

┌────────────────────────────┬────────┬─────────┬─────────────┬─────────┐
│                      Label │  Tapir │  Zygote │ ReverseDiff │  Enzyme │
│                     String │ String │  String │      String │  String │
├────────────────────────────┼────────┼─────────┼─────────────┼─────────┤
│                        sum │   30.4 │   0.324 │        2.34 │   0.479 │
│                       _sum │   6.76 │   484.0 │        27.5 │   0.126 │
│                   kron_sum │   81.7 │    3.34 │       210.0 │    23.5 │
│              kron_view_sum │   96.1 │    11.6 │       244.0 │    8.73 │
│      naive_map_sin_cos_exp │   4.33 │ missing │        8.73 │    2.78 │
│            map_sin_cos_exp │    4.7 │    1.74 │        7.63 │    3.43 │
│      broadcast_sin_cos_exp │   4.35 │    2.62 │        1.69 │    2.88 │
│                 simple_mlp │   12.6 │     3.2 │        11.2 │    3.31 │
│                     gp_lml │   15.7 │    4.06 │     missing │ missing │
│ turing_broadcast_benchmark │   6.35 │ missing │        34.9 │ missing │
└────────────────────────────┴────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit 24404e9 into main May 14, 2024
16 checks passed
@willtebbutt willtebbutt deleted the wct/verify-safe-rrule branch May 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant