Skip to content

Commit

Permalink
Make use of new MistyClosure functionality (#296)
Browse files Browse the repository at this point in the history
  • Loading branch information
@willtebbutt
willtebbutt authored Oct 20, 2024
1 parent b443cb4 commit 50e8d9c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Mooncake"
uuid = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
authors = ["Will Tebbutt, Hong Ge, and contributors"]
version = "0.4.12"
version = "0.4.13"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down Expand Up @@ -55,7 +55,7 @@ Graphs = "1"
JET = "0.9"
LogDensityProblemsAD = "1"
LuxLib = "1.2 - 1.3.3"
MistyClosures = "1"
MistyClosures = "1.0.3"
NNlib = "0.9"
PDMats = "0.11"
Setfield = "1"
Expand Down
10 changes: 2 additions & 8 deletions src/interpreter/s2s_reverse_mode_ad.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -930,14 +930,8 @@ function build_rrule(
# @show length(stmt(ir.stmts))
# @show length(stmt(optimised_fwds_ir.stmts))
# @show length(stmt(optimised_pb_ir.stmts))
fwds_oc = MistyClosure(
OpaqueClosure(optimised_fwds_ir, shared_data...; do_compile=true),
optimised_fwds_ir,
)
pb_oc = MistyClosure(
OpaqueClosure(optimised_pb_ir, shared_data...; do_compile=true),
optimised_pb_ir,
)
fwds_oc = MistyClosure(optimised_fwds_ir, shared_data...; do_compile=true)
pb_oc = MistyClosure(optimised_pb_ir, shared_data...; do_compile=true)

# Compute the signature. Needs careful handling with varargs.
sig = sig_or_mi isa Core.MethodInstance ? sig_or_mi.specTypes : sig_or_mi
Expand Down

2 comments on commit 50e8d9c

@willtebbutt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/117673

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.13 -m "<description of version>" 50e8d9c2b1b682a800bff2908db6a39629e5b9cc
git push origin v0.4.13

Please sign in to comment.