Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure all RFC1918 local Ipv4 addresses are in iptag script #992

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

AskAlice
Copy link
Contributor

@AskAlice AskAlice commented Dec 23, 2024

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

i ran the LXC ip tag script but my local ip addresses weren't getting tagged until i added the CIDR for my 172.16/12 range

Interestingly there is a bogon network included here which most commonly. in my experience. is used for tailscale, I suppose it can be left in



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • [ x Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@AskAlice AskAlice requested a review from a team as a code owner December 23, 2024 18:05
@github-actions github-actions bot added the update script A change that updates a script label Dec 23, 2024
@MickLesk
Copy link
Member

Only for your use or for tailscale for everyone?

Everyone can edit the config file himself...

@MickLesk MickLesk merged commit 8f243c7 into community-scripts:main Dec 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants